Remove unnecessary chart updates on drags #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kurkle Would be nice to see this one move along |
|
Anything I can do to help get this merged? |
kurkle
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes a few
chart.update()calls in the zoom drag handler (i.e. mouse down, mouse move, mouse up) to just usechart.draw()instead. The chart update was unnecessary since none of the chart elements had updated. It is also much more expensive to update the chart (incurring costs of things like recomputing the ticks, recomputing any datapoint styling using chart context, etc.) than just to redraw the chart. In some cases with lots of datapoints, this speeds up the function from 100ms -> 1ms. As far as I can tell, the only purpose of thechart.update()call was to repaint the shaded area being zoomed, butchart.draw()achieves the same purpose.