Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label alignment option to axis label title #6521

Merged
merged 11 commits into from
Oct 27, 2019
Merged

Add label alignment option to axis label title #6521

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cea8546
Add label alignment option to axis label title
el Sep 15, 2019
7ecdf3a
Documentation and style fixes
el Sep 16, 2019
c9c7f48
Fix alignment based on position
el Sep 16, 2019
dc04813
Use start as bottom
el Sep 19, 2019
4fe3f2e
use isreverse for reverse option
el Sep 19, 2019
1f40f09
Replace labelAlign with align
el Oct 4, 2019
7da5f6b
Rename the variable
el Oct 5, 2019
b5c2d2f
Review comments ...
el Oct 7, 2019
2c7df51
Update ternary operation
el Oct 7, 2019
2ca863e
Fix horizontal layout issue
el Oct 18, 2019
ff3c5ed
Remove unnecessary variable
el Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Documentation and style fixes
  • Loading branch information
@el
el committed Sep 16, 2019
commit 7ecdf3a2e26a6ed0cf0b3111a2ba9b10bc3a50db
2 changes: 1 addition & 1 deletion docs/axes/labelling.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ The scale label configuration is nested under the scale configuration in the `sc
| Name | Type | Default | Description
| ---- | ---- | ------- | -----------
| `display` | `boolean` | `false` | If true, display the axis title.
| `labelAlign` | `string` | `center` | Alignment of the axis title. Possible options are `start`, `center` and `end`
| `labelAlign` | `string` | `'center'` | Alignment of the axis title. Possible options are `'start'`, `'center'` and `'end'`
| `labelString` | `string` | `''` | The text for the title. (i.e. "# of People" or "Response Choices").
| `lineHeight` | <code>number&#124;string</code> | `1.2` | Height of an individual line of text (see [MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/line-height)).
| `fontColor` | `Color` | `'#666'` | Font color for scale title.
Expand Down
10 changes: 4 additions & 6 deletions src/core/core.scale.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1211,8 +1211,7 @@ var Scale = Element.extend({
var scaleLabelX, scaleLabelY, textAlign;

if (me.isHorizontal()) {
switch (scaleLabelAlign)
{
switch (scaleLabelAlign) {
case 'start':
scaleLabelX = me.left;
textAlign = 'left';
Expand All @@ -1234,14 +1233,13 @@ var Scale = Element.extend({
? me.left + halfLineHeight + scaleLabelPadding.top
: me.right - halfLineHeight - scaleLabelPadding.top;
var height = me.height;
switch (scaleLabelAlign)
{
switch (scaleLabelAlign) {
case 'start':
scaleLabelY = me.top + ( isLeft ? height : 0 );
scaleLabelY = me.top + (isLeft ? height : 0);
textAlign = isLeft ? 'left' : 'right';
break;
case 'end':
scaleLabelY = me.top + ( isLeft ? 0 : height );
scaleLabelY = me.top + (isLeft ? 0 : height);
textAlign = isLeft ? 'left' : 'right';
break;
default:
Expand Down