Attempt to fix test flakiness #4880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
requested changes
Oct 22, 2017
karma.conf.js
Outdated
| } | ||
| }, | ||
|
|
||
| browserNoActivityTimeout: 500000, |
There was a problem hiding this comment.
500000 (8.20 minutes) is quite a lot, we could start with 1 or 2 minutes. Can you also add a comment above these values to explain why and a link to the ticket/article/docs where you found that solution?
There was a problem hiding this comment.
Oops. I meant to set to 50000 not 500000. I've updated it to be 1 min and added a comment as suggested. Thanks for catching that
etimberg
approved these changes
Oct 22, 2017
simonbrunel
approved these changes
Oct 22, 2017
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
These settings deal with browser disconnects. We had seen test flakiness from Firefox: [Firefox 56.0.0 (Linux 0.0.0)]: Disconnected (1 times), because no message in 10000 ms
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
These settings deal with browser disconnects. We had seen test flakiness from Firefox: [Firefox 56.0.0 (Linux 0.0.0)]: Disconnected (1 times), because no message in 10000 ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like these settings have fixed the problems we're seeing on Travis for others
E.g. jasmine/jasmine#1327 (comment)