Fix responsive issue when the chart is recreated #4774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome specific issue that happens when destroying a chart and re-creating it immediately (same animation frame?). The CSS animation used to detect when the canvas become visible is not re-evaluated, breaking responsiveness. Accessing the `offsetParent` property will force a reflow and re-evaluate the CSS animation.
simonbrunel
force-pushed
the
fix/4737
branch
from
110050d to
49d07f0
Compare
|
Firefox has some issues with the first fix (manually trigger handlers), so simply force a reflow by accessing the |
simonbrunel
commented
Sep 18, 2017
| try { | ||
| chart = new Chart(canvas.getContext('2d'), config); | ||
| } catch (e) { | ||
| window.document.body.removeChild(wrapper); |
There was a problem hiding this comment.
This test was leaking because the chart construction throws and the wrapper/canvas wasn't removed.
etimberg
approved these changes
Sep 18, 2017
|
@daniele-orlando @frlinw can you have a look at this PR and confirm that it fixes your issue? |
|
Hi Simon, sorry I'm in Singapore for 2 weeks with just my phone, I'll check when I'll be back in my cold country |
|
@frlinw have you had a chance to test this? |
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
Chrome specific issue that happens when destroying a chart and re-creating it immediately (same animation frame?). The CSS animation used to detect when the canvas become visible is not re-evaluated, breaking responsiveness. Accessing the `offsetParent` property will force a reflow and re-evaluate the CSS animation.
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Chrome specific issue that happens when destroying a chart and re-creating it immediately (same animation frame?). The CSS animation used to detect when the canvas become visible is not re-evaluated, breaking responsiveness. Accessing the `offsetParent` property will force a reflow and re-evaluate the CSS animation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome specific issue that happens when destroying a chart and re-creating it immediately (same animation frame?). The CSS animation used to detect when the canvas become visible is not re-evaluated, breaking responsiveness. Accessing the
offsetParentproperty will force a reflow and re-evaluate the CSS animation.Fixes #4737