-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OSX build #4617
Fix OSX build #4617
Conversation
}, | ||
// https://github.com/karma-runner/gulp-karma/issues/18 | ||
function(error) { | ||
error = error ? new Error('Karma returned with the error code: ' + error) : undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that works, but to be sure, can you push a change that makes a test to fail. I'm curious to see how the Travis build behaves and how errors are reported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I agree with @simonbrunel's comment about confirming that the CI can still fail
Here's the output of a failed test:
Previously, this would show a gulp |
fix #4515 as per discussion. I had to add two tweaks to make SublimeText and gulp behave, too.