Enforce variable declaration coding style #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency, enable ESLint `one-var` rule to require multiple variable declarations for initialized variables per scope. Uninitialized variables can still be declared together (preferred) or separately. http://eslint.org/docs/rules/one-var
etimberg
approved these changes
Aug 3, 2017
panzarino
approved these changes
Aug 3, 2017
|
lgtm |
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
For consistency, enable ESLint `one-var` rule to require multiple variable declarations for initialized variables per scope. Uninitialized variables can still be declared together (preferred) or separately. http://eslint.org/docs/rules/one-var
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
For consistency, enable ESLint `one-var` rule to require multiple variable declarations for initialized variables per scope. Uninitialized variables can still be declared together (preferred) or separately. http://eslint.org/docs/rules/one-var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long time ago we agreed on multiple variable declarations for initialized variables, however we never made this style a rule. Some of the old code still uses the one variable declaration approach, same for a few submitted PR. So for consistency, let's enable the ESLint
one-varrule to require multiple variable declarations for initialized variables per scope. Uninitialized variables can still be declared together (preferred) or separately.I think this article describes pretty well the reasons of that move.