Fix onHover event not being triggered #4297
Conversation
|
An alternative solution is to say that the docs are right and what we want but make the change in a way that keeps backwards compatibility with the old |
|
@etimberg, @simonbrunel What do you think of exposing This will allow developers interested only in knowing if the hovering state changed ( |
The core controller was looking at the wrong object (options.hover) to find the function to be called on hover. The function is provided on the top level options object (options.onHover). Fixes #4296
|
@etimberg Per @simonbrunel's feedback on #4296, I've added the fallback to the "old" |
src/core/core.controller.js
Outdated
| // Need to call with native event here to not break backwards compatibility | ||
| hoverOptions.onHover.call(me, e.native, me.active); | ||
| hoverCallback.call(me, e.native, me.active); |
There was a problem hiding this comment.
Might be more concise using helpers.callback(options.onHover || options.hover.onHover, [e.native, me.active], me), then no need to test if hoverCallback is defined/null.
By using the helper function, there's no need to verify if the callback is defined, as the helper already does that.
Fix onHover event not being triggered The core controller was looking at the wrong object (options.hover) to find the function to be called on hover. The function is provided on the top level options object (options.onHover). By using the helper function, there's no need to verify if the callback is defined, as the helper already does that. Fixes chartjs#4296
The core controller was looking at the wrong object (options.hover) to find the function to be called on hover. The function is provided on the top level options object (options.onHover).
Fixes #4296