-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the correct area to clip for dataset drawing when stacked scales are used #10691
Conversation
It's not clear to me how to fix the CI job. Error creating comment. This can happen for PR's originating from a fork without write permissions.
Error: Size limit has been exceeded. |
Seems that this line has to be increased to 77.2 ish so its bit safe for the future: Line 10 in 1253ced
Weird that it ran twice in which one time it was over and one time it wasn't. |
@LeeLenaleee thank you very much. Do you think I can change that file setting new value? |
Yes you can, otherwise CI will keep failing |
Sounds fixed!!! Thank you @LeeLenaleee |
I see the error PR #10707 |
|
I was having a look the second execution. |
It was enough as you can see in the first screenshot but now this code contains more bytes compiled as you can see in the second screenshot EDIT MB big jump is because of my MR #10702 |
Co-authored-by: Jacco van den Berg <[email protected]>
…art.js.git into fixStackedScales
@kurkle did you still want to review this? |
Fix #10686
TODO