undefined options, fix test

chartjs · Feb 6, 2021 · fe13dd1 · fe13dd1
1 parent 73a0b54
commit fe13dd1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/core/core.datasetController.js b/src/core/core.datasetController.js
@@ -808,8 +808,8 @@ export default class DatasetController {
 			options = config.createResolver(scopes, context);
 		}
 		const animations = new Animations(chart, options && options[mode] || options);
-		if (options._cacheable) {
-			cache[cacheKey] = animations && Object.freeze(animations);
+		if (options && options._cacheable) {
+			cache[cacheKey] = Object.freeze(animations);
 		}
 		return animations;
 	}

diff --git a/test/specs/core.animations.tests.js b/test/specs/core.animations.tests.js
@@ -11,7 +11,7 @@ describe('Chart.animations', function() {
 			}
 		});
 		expect(anims._properties.get('property1')).toEqual(jasmine.objectContaining({duration: 1000}));
-		expect(anims._properties.get('property2')).toEqual({duration: 2000});
+		expect(anims._properties.get('property2')).toEqual(jasmine.objectContaining({duration: 2000}));
 	});
 
 	it('should ignore duplicate definitions from collections', function() {