Add TLS support for http #39
Conversation
Signed-off-by: andrewmatilde <[email protected]>
Signed-off-by: andrewmatilde <[email protected]>
Signed-off-by: andrewmatilde <[email protected]>
Signed-off-by: andrewmatilde <[email protected]>
Signed-off-by: andrewmatilde <[email protected]>
Signed-off-by: andrewmatilde <[email protected]>
Signed-off-by: andrewmatilde <[email protected]>
Signed-off-by: andrewmatilde <[email protected]>
Signed-off-by: andrewmatilde <[email protected]>
# Conflicts: # Cargo.lock # Cargo.toml # chaos-tproxy-controller/Cargo.toml # chaos-tproxy-proxy/Cargo.toml # chaos-tproxy-proxy/src/proxy/http/server.rs
Signed-off-by: andrewmatilde <[email protected]>
Signed-off-by: andrewmatilde <[email protected]>
| derivative = "2.2.0" | ||
| rustls-pemfile = "1.0.0" | ||
| webpki-roots = "0.22" | ||
| hyper-rustls = { git = "https://github.com/Andrewmatilde/hyper-rustls.git", features = ["http2"] } |
There was a problem hiding this comment.
Maybe we can use dependency override to replace hyper globally instead of modifying it in each dependency.
There was a problem hiding this comment.
I think this is not the common use case of dependency override
There was a problem hiding this comment.
Lucky, something we need just merged rust-lang/cargo#10497
There was a problem hiding this comment.
I know what's the problem , I will fix it.
There was a problem hiding this comment.
It seems dependency override not fix the problem.
| tracing::debug!(target : "Accept streaming", "remote={:?}, local={:?}", | ||
| addr_remote, addr_local); | ||
| let service = HttpService::new(addr_remote, | ||
| addr_local, |
There was a problem hiding this comment.
Please format the code, there should be some idents.
There was a problem hiding this comment.
That didn't auto fmt becuase the code are inside the macro.
| } | ||
| } | ||
|
|
||
| loop { |
There was a problem hiding this comment.
Why not merge the two loops by a bit of abstraction?
There was a problem hiding this comment.
It seems there are only three lines code are same , so I think we do not need give an abstrction here.
| @@ -89,15 +153,15 @@ pub async fn serve_http_with_error_return( | |||
| }, | |||
| Err(e) => { | |||
| return if e.is_parse() { | |||
| tracing::debug!("{}:Turn into tcp transfer.", log_key); | |||
| debug!("{}:Turn into tcp transfer.", log_key); | |||
There was a problem hiding this comment.
Please use the span instead of log_key.
| parts.scheme = Some(Scheme::HTTP); | ||
| } | ||
|
|
||
| *request.uri_mut() = Uri::from_parts(parts)?; | ||
|
|
||
| let client = Client::builder().build(HttpConnector::new(self.remote)); | ||
| let mut response = if let Some(tls_client_config) = &self.tls_client_config { |
There was a problem hiding this comment.
There is duplicated code in two cases of if-else, please reuse them.
Signed-off-by: andrewmatilde <[email protected]>
Signed-off-by: andrewmatilde <[email protected]>
Signed-off-by: andrewmatilde <[email protected]>
Signed-off-by: andrewmatilde <[email protected]>
Signed-off-by: andrewmatilde <[email protected]>
|
PTAL @Hexilee |
related issue :
#42
Signed-off-by: andrewmatilde [email protected]