feat: fogg create tfe folder #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakeyheath
commented
Sep 16, 2022
| @@ -30,7 +30,7 @@ import ( | |||
| const rootPath = "terraform" | |||
|
|
|||
| // Apply will run a plan and apply all the changes to the current repo. | |||
| func Apply(fs afero.Fs, conf *v2.Config, tmp *templates.T, upgrade bool) error { | |||
| func Apply(fs afero.Fs, conf *v2.Config, tmpl *templates.T, upgrade bool) error { | |||
There was a problem hiding this comment.
tmp was confusing to me since it sounded like temporary
jakeyheath
commented
Sep 16, 2022
| comp2: {} | ||
| accounts: | ||
| account: {} | ||
| tfe: |
There was a problem hiding this comment.
example of how to add this support to your fogg yml
jakeyheath
commented
Sep 16, 2022
testdata/tfe_config/fogg.yml
Outdated
| gh_org: chanzuckerberg | ||
| gh_repo: fogg | ||
| tfe_org: si.prod.tfe.czi.technology | ||
| module_source: github.com/chanzuckerberg/cztack//aws-params-reader-policy?ref=v0.15.1 |
There was a problem hiding this comment.
in the real world, you would use something like [email protected]:chanzuckerberg/shared-infra//terraform/modules/tfe-management?ref=tfe-management-v1.0.0
There was a problem hiding this comment.
I had to change it so CICD would pass since its a private module
alexlokshin-czi
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a feature to fogg that adds an optional tfe/ folder to synchronize fogg env/accounts with tfe workspaces.