feat(scripts): allow import script to pull using Figma API #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2132 +/- ##
==========================================
- Coverage 97.13% 96.96% -0.18%
==========================================
Files 114 114
Lines 2829 2898 +69
Branches 764 781 +17
==========================================
+ Hits 2748 2810 +62
- Misses 77 84 +7
Partials 4 4 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
booc0mtaco
force-pushed
the
aholloway/EDS-1471
branch
2 times, most recently
from
d9f8e5a to
0eea26d
Compare
booc0mtaco
commented
Feb 19, 2025
| @@ -99,7 +99,7 @@ | |||
| "jsonfile": "^6.1.0", | |||
| "lilconfig": "^3.1.3", | |||
| "lodash": "^4.17.21", | |||
| "ora": "^8.1.1", | |||
| "ora": "5.4.1", | |||
There was a problem hiding this comment.
note: locking ora to a pre ESM release to avoid import issues and incompatibility with pre v30 of jest
booc0mtaco
force-pushed
the
aholloway/EDS-1471
branch
from
0eea26d to
f814322
Compare
- handle both downloaded file version and API version - handle input and edge cases (e.g., missing config) - separate and handle parsing of token contents into theme file - guard against committing local edsrc config
booc0mtaco
force-pushed
the
aholloway/EDS-1471
branch
from
f814322 to
6fffc39
Compare
ajmoreno
approved these changes
Feb 20, 2025
|
Holding merge until release completes to keep the history on |
Yahhhh. adding these classes to make dealing with all the weird data a little more straight-forward... more to come :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we also flag instances of mismatches between figma and code, for later fixing (in Figma). Example:
Test Plan: