Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(InputField): add stories for date and time support #2009

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

booc0mtaco
Copy link
Contributor

  • document ability with stories
  • add snapshots for the UI icons generated by the browsers

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Created and used an alpha publish
  • Manually tested my changes, and here are the details:

- document ability with stories
- add snapshots for the UI icons generated by the browsers
@booc0mtaco
Copy link
Contributor Author

Screen.Recording.2024-07-08.at.13.24.06.mov

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (661130b) to head (9fe3952).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2009      +/-   ##
==========================================
- Coverage   97.58%   97.39%   -0.20%     
==========================================
  Files         109      109              
  Lines        2572     2572              
  Branches      645      645              
==========================================
- Hits         2510     2505       -5     
- Misses         60       65       +5     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 8, 2024

size-limit report 📦

Path Size
components 88.47 KB (0%)
styles 27.65 KB (0%)

@booc0mtaco booc0mtaco requested a review from a team July 8, 2024 19:02
@@ -26,7 +26,6 @@ const meta: Meta<typeof InputField> = {
options: [
'text',
'password',
'datetime',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was removed form the supported standard, and get treated like a text field, so removing from our types and storybook control

@booc0mtaco
Copy link
Contributor Author

Note: the date/time formats here are locale-specific; the browser uses the the format as defined by the user's computer, so that's why it shows up in yyyy-mm-dd format here

@booc0mtaco booc0mtaco merged commit 94636ec into next Jul 11, 2024
10 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1269 branch July 11, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants