feat(Avatar): adjust typography usages and sizing for icons #1830
+41
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use typography token values from design - scale icons at 80 percent of size value, centered vertically and horizontally
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1830 +/- ##
=======================================
Coverage 92.50% 92.50%
=======================================
Files 147 147
Lines 2760 2761 +1
Branches 739 740 +1
=======================================
+ Hits 2553 2554 +1
Misses 191 191
Partials 16 16 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
ahuth
approved these changes
Jan 18, 2024
Merged
booc0mtaco
added a commit
that referenced
this pull request
Jan 19, 2024
## [13.9.0](v13.8.1...v13.9.0) (2024-01-19) [Storybook](https://61313967cde49b003ae2a860-utfzotmwuw.chromatic.com/) ### Features * **Avatar:** adjust typography usages and sizing for icons ([#1830](#1830)) ([7da31e6](7da31e6)) * **InlineNotification:** remove deprecated variants ([#1833](#1833)) ([cfcf1fa](cfcf1fa)) * **Label:** mark optional as deprecated ([#1832](#1832)) ([8067082](8067082)) * **tokens:** output token literal values in a new tailwind config file ([#1828](#1828)) ([08fa1c4](08fa1c4)) ### Bug Fixes * **InputField:** mark unused prop as deprecated ([#1831](#1831)) ([622abfb](622abfb)) * **Select:** update incorrect documentation ([#1825](#1825)) ([94aace5](94aace5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: