Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps): bump @testing-library/react to v14 (#1515)" #1523

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

jinlee93
Copy link
Contributor

@jinlee93 jinlee93 commented Mar 2, 2023

Summary:

  • was getting a bunch of error messages about state updates not being wrapped in act after bump to v14
    image
  • reverts so these are gone
    image
  • also sneaks in moving mocks to test blocks b/c for some reason those were logging error messages in the console too

testing-library/user-event#1104

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Manually tested my changes, and here are the details:
    • Create an alpha publish and try out in edu-stack or traject as a sanity check if changes affect build or deploy, or are breaking, such as token changes, widely used component updates, hooks changes, and major dependency upgrades.

@jinlee93 jinlee93 requested a review from a team March 2, 2023 23:34
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #1523 (05e6f28) into next (bc21f85) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1523   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files         284      284           
  Lines        4300     4300           
  Branches      793      793           
=======================================
  Hits         3955     3955           
  Misses        320      320           
  Partials       25       25           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jinlee93 jinlee93 merged commit d37798c into next Mar 3, 2023
@jinlee93 jinlee93 deleted the jlee/revertTestingLibraryReact branch March 3, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants