Remove bootstrap override hooks #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #1512 +/- ##
==========================================
- Coverage 91.91% 91.91% -0.01%
==========================================
Files 277 277
Lines 4180 4179 -1
Branches 755 755
==========================================
- Hits 3842 3841 -1
Misses 313 313
Partials 25 25
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
size-limit report 📦
|
|
Thanks! |
|
@ahuth Ah, i wish i had seen this sooner; I was hoping to keep any breaking changes out of the release this week to exercise some PR sorting. Luckily this one is breaking as a technicality (unless someone is sneakily using those attributes...) |
|
Got excited. Can revert, @booc0mtaco. Although definitely no-one using them in GST. |
|
@ahuth It's all good; we can keep this in, and go to the next major. I wonder if the tooling knows how to handle a revert of a breaking change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDS-850
Remove the
data-bootstrap-overridehooks. They're not needed anymore, because LP is staying on EDS v8.