Update some deps #1509
Merged
Update some deps #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuth
commented
Feb 24, 2023
Comment on lines
+24
to
+25
| // Don't run axe on this story. The video seems to cause asset preloading to fail (even when | ||
| // the video has preload="none"). |
There was a problem hiding this comment.
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## next #1509 +/- ##
=======================================
Coverage 91.91% 91.91%
=======================================
Files 277 277
Lines 4180 4180
Branches 755 755
=======================================
Hits 3842 3842
Misses 313 313
Partials 25 25 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jinlee93
reviewed
Feb 24, 2023
| @@ -127,22 +127,22 @@ | |||
| "@types/react-beautiful-dnd": "^13.1.3", | |||
| "@types/react-dom": "^18.0.11", | |||
| "@types/react-portal": "^4.0.4", | |||
| "axe-core": "4.4.3", | |||
| "chromatic": "^6.17.0", | |||
| "axe-core": "4.6.3", | |||
There was a problem hiding this comment.
^4.6.3?
Iirc we kept it at 4.4.3 due to timeouts but it looks like we're just skipping that. Can we remove axe-core from the ignore in the renovate config?
There was a problem hiding this comment.
Can we add the caret back (shoulda been more clear lol sorry)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates some deps.