test(Select): add story for selected value #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a new story for showing a value selected on component load - update typing in story file for clarity
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## next #1507 +/- ##
=======================================
Coverage 91.91% 91.91%
=======================================
Files 277 277
Lines 4178 4180 +2
Branches 755 755
=======================================
+ Hits 3840 3842 +2
Misses 313 313
Partials 25 25
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jinlee93
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is to ensure the behavior of selected values when using the component, as this was not previously covered in our wrapper
Test Plan:
edu-stackortrajectas a sanity check if changes affect build or deploy, or are breaking, such as token changes, widely used component updates, hooks changes, and major dependency upgrades.