Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(badge): suppress expected console error #1502

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

jinlee93
Copy link
Contributor

Summary:

  • suppresses expected console error that was missed previously

Test Plan:

  • CI tests / new tests are not applicable

@jinlee93 jinlee93 requested a review from a team February 17, 2023 20:18
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1502 (4425199) into next (8067e02) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1502   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files         272      272           
  Lines        4113     4113           
  Branches      728      728           
=======================================
  Hits         3779     3779           
  Misses        332      332           
  Partials        2        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

size-limit report 📦

Path Size
components 116.22 KB (0%)
styles 3.1 KB (0%)

Copy link
Contributor

@booc0mtaco booc0mtaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future reference, you can nest describe blocks, so if we ever end up with a bunch of tests that require mocking things like this, we can have describe('on error') and an appropriate before and after each just for that one 🧰

@jinlee93
Copy link
Contributor Author

for future reference, you can nest describe blocks, so if we ever end up with a bunch of tests that require mocking things like this, we can have describe('on error') and an appropriate before and after each just for that one 🧰

ahh makes sense

@jinlee93 jinlee93 merged commit 5abd719 into next Feb 17, 2023
@jinlee93 jinlee93 deleted the jlee/suppressConsoleErrorBadge branch February 17, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants