Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Gradle shadow plugin fork #414

Closed
1 task done
joshuasing opened this issue Jun 17, 2024 · 0 comments · Fixed by #415
Closed
1 task done

Move to Gradle shadow plugin fork #414

joshuasing opened this issue Jun 17, 2024 · 0 comments · Fixed by #415
Assignees
@joshuasing
Labels
area: build This involves updating, adding or removing a build file type: dependencies This involves updating, adding or removing a dependency type: enhancement This is a feature request or a pull request that adds a feature

Comments

@joshuasing
Copy link
Member

Confirmation

  • I have checked for similar issues.

Problem

The Gradle shadow plugin by johnrengelman is currently unmaintained, there has been discussions about what to do with the plugin and who is going to continue maintaining it, however nothing has been acted upon: GradleUp/shadow#908

Suggested solution

"Goooler" has forked the shadow plugin repository and has been maintaining it in a new repository: https://github.com/Goooler/shadow

It looks like the issue mentioned above discusses moving to this fork and deprecating the original, or merging it into a new repository to continue development.

I propose that we switch to using this fork until the original is replaced by something else, or continue using this fork if the original is deprecated.

Additional information

No response
@joshuasing joshuasing added type: enhancement This is a feature request or a pull request that adds a feature type: dependencies This involves updating, adding or removing a dependency area: build This involves updating, adding or removing a build file labels Jun 17, 2024
@joshuasing joshuasing self-assigned this Jun 17, 2024
joshuasing added a commit that referenced this issue Jun 17, 2024
@joshuasing
build: switch to Goooler/shadow fork
51480a4 
The Gradle shadow plugin by johnrengelman is currently unmaintained, and
does not currently support the latest versions of Gradle.

There have been discussions regarding the future of the plugin, however
nothing has been acted upon currently: GradleUp/shadow#908

This fork appears to be the most supported and best maintained fork, and
has been suggested as the replacement for the original shadow plugin.

Fixes #414
Related to #410
@joshuasing joshuasing mentioned this issue Jun 17, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuasing joshuasing

Labels
area: build This involves updating, adding or removing a build file type: dependencies This involves updating, adding or removing a dependency type: enhancement This is a feature request or a pull request that adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: switch to Goooler/shadow fork chameleonframework/chameleon
1 participant
@joshuasing