Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue#6982 -- PM128A should be a pointer to 16-byte aligned M128U, not a 16-byte aligned pointer. #6983

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

EmployedRussian
Copy link
Contributor

No description provided.

Copy link
Member

@ppenzin ppenzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After thinking for a bit I think you are right, declspec_align applies to the pointer when it should not.

@ppenzin
Copy link
Member

ppenzin commented Apr 21, 2024

#6982 (for convenience)

Copy link
Member

@ppenzin ppenzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Upstream (dotnet) PAL got rid of the extra layer of pointers by moving alignment to struct declaration above the line, though that requires some extra changes in other places.

@rhuanjl what do you think?

@ppenzin ppenzin requested a review from rhuanjl April 21, 2024 05:18
@rhuanjl rhuanjl merged commit a2aae95 into chakra-core:master Apr 21, 2024
24 checks passed
@rhuanjl
Copy link
Collaborator

rhuanjl commented Apr 21, 2024

Looks good to me. Upstream (dotnet) PAL got rid of the extra layer of pointers by moving alignment to struct declaration above the line, though that requires some extra changes in other places.

@rhuanjl what do you think?

Long term I'd like to get rid of more PAL if we can but this seems fine to me for now; I went ahead and merged it - can always revisit if we see further problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants