Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS#11664710: Intl: Check hr for failure immediately after it is set. #4409

Merged
merged 1 commit into from
Dec 12, 2017
Merged

OS#11664710: Intl: Check hr for failure immediately after it is set. #4409

merged 1 commit into from
Dec 12, 2017

Conversation

dilijev
Copy link
Contributor

@dilijev dilijev commented Dec 12, 2017

No description provided.

@dilijev dilijev requested a review from jackhorton December 12, 2017 02:18
@dilijev dilijev self-assigned this Dec 12, 2017
@dilijev dilijev changed the title OS#11664710: Check hr for failure immediately after it is set. OS#11664710: Intl: Check hr for failure immediately after it is set. Dec 12, 2017
@dilijev
Copy link
Contributor Author

dilijev commented Dec 12, 2017 •
edited
Loading

@Cellule does that wasm failure look familiar? https://ci2.dot.net/job/Microsoft_ChakraCore/job/release_1.8/job/shared_ubuntu_linux_debug_prtest/248/

@dilijev
Copy link
Contributor Author

dilijev commented Dec 12, 2017

@dotnet-bot test Ubuntu shared_ubuntu_linux_debug please

agarwal-sandeep
agarwal-sandeep approved these changes Dec 12, 2017
View reviewed changes
Copy link
Collaborator

@agarwal-sandeep agarwal-sandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chakrabot chakrabot merged commit 0bafc18 into chakra-core:release/1.8 Dec 12, 2017
chakrabot pushed a commit that referenced this pull request Dec 12, 2017
@dilijev
[MERGE #4409 @dilijev] OS#11664710: Intl: Check hr for failure immedi…
1750fb6 
…ately after it is set.

Merge pull request #4409 from dilijev:intl-check-hr
chakrabot pushed a commit that referenced this pull request Dec 12, 2017
@dilijev
[1.8>master] [MERGE #4409 @dilijev] OS#11664710: Intl: Check hr for f…
94e66c5 
…ailure immediately after it is set.

Merge pull request #4409 from dilijev:intl-check-hr
@dilijev dilijev mentioned this pull request Dec 12, 2017
Closed
@dilijev dilijev deleted the intl-check-hr branch January 31, 2018 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackhorton jackhorton jackhorton approved these changes

@agarwal-sandeep agarwal-sandeep agarwal-sandeep approved these changes

Assignees

@dilijev dilijev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dilijev @jackhorton @agarwal-sandeep @chakrabot