Fix a few issues blocking ASAN runs #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a host issue, but should be fixed at some point. Tracked in GitHub bug chakra-core#2735.
MikeHolman
approved these changes
Jun 9, 2017
|
|
chakrabot
pushed a commit
that referenced
this pull request
Jun 9, 2017
Merge pull request #3129 from Penguinwizzard:fix_asan_ci Disable one test in ASAN due to a known issue with modules in ch (bug #2735), disable one test on xplat due to wasm calling convention issues (bug #2378), keep a loop from accessing data beyond an array bound in the pal code, and fix the casing on one test file.
chakrabot
pushed a commit
that referenced
this pull request
Jun 9, 2017
…ASAN runs Merge pull request #3129 from Penguinwizzard:fix_asan_ci Disable one test in ASAN due to a known issue with modules in ch (bug #2735), disable one test on xplat due to wasm calling convention issues (bug #2378), keep a loop from accessing data beyond an array bound in the pal code, and fix the casing on one test file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable one test in ASAN due to a known issue with modules in ch (bug #2735), disable one test on xplat due to wasm calling convention issues (bug #2378), keep a loop from accessing data beyond an array bound in the pal code, and fix the casing on one test file.