Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable WebAssembly on xplat #3561

Closed
3 tasks done
Cellule opened this issue Aug 21, 2017 · 4 comments
Closed
3 tasks done

Enable WebAssembly on xplat #3561

Cellule opened this issue Aug 21, 2017 · 4 comments
Assignees
@MikeHolman
Labels
Linux OSX Task WebAssembly
Milestone
vNext

Comments

@Cellule
Copy link
Contributor

Cellule commented Aug 21, 2017 •
edited
Loading

  • Remove exclude_xplat tag from test folder WasmSpec and from individual tests in test folder wasm
  • Fix failing tests
  • Enable WebAssembly in release builds (remove #if defined(_WIN32) || (defined(__clang__) && defined(ENABLE_DEBUG_CONFIG_OPTIONS)) in CommonDefines.h
@Cellule Cellule added this to the vNext milestone Aug 21, 2017
@Cellule Cellule mentioned this issue Aug 21, 2017
Closed
@obastemur
Copy link
Collaborator

@Cellule any update on this?

@Cellule
Copy link
Contributor Author

Cellule commented Nov 21, 2017

We haven't allocated any resources to fix the issues that we have yet.
We have recently disabled WebAssembly by default even on test builds.

@ghost
Copy link

ghost commented Nov 23, 2017

Is this scheduled for next quarter? If it's just about the build configuration / cmake issue, would be sad to see 2017 passing by without wasm support on unix.. :(

@digitalinfinity
Copy link
Contributor

@kasper3 curious, do you have a specific use case in mind for WASM on Unix using ChakraCore?

@MikeHolman MikeHolman mentioned this issue Jan 11, 2018
Merged
chakrabot pushed a commit that referenced this issue Jan 12, 2018
@MikeHolman
[1.8>master] [MERGE #4531 @MikeHolman] fix and enable wasm on xplat
79df905 
Merge pull request #4531 from MikeHolman:fixwasmxplat

fix issues with calling convention: we are using stack based calling convention, so we can cleanup a lot of code that was complicated by xmm registers.

fix issue where JIT was calling wrong method for floorf and ceilf

Resolves #3561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeHolman MikeHolman

Labels
Linux OSX Task WebAssembly
Projects
None yet
Milestone
vNext
Development

No branches or pull requests
4 participants
@digitalinfinity @Cellule @obastemur @MikeHolman