Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor dependencies, features, remove prover service trait and sov-stf-runner #1843

Merged
merged 4 commits into from
Feb 8, 2025

Conversation

eyusufatik
Copy link
Member

Description

Linked Issues

  • Fixes # (issue, if applicable)
  • Related to # (issue)

Testing

Describe how these changes were tested. If you've added new features, have you added unit tests?

Docs

Describe where this code is documented. If it changes a documented interface, have the docs been updated?

Copy link
Contributor

@rakanalh rakanalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less code is better code

crates/common/src/lib.rs Show resolved Hide resolved
@eyusufatik eyusufatik changed the title refactor dependencies, features and remove sov-stf-runner refactor dependencies, features, remove prover service trait and sov-stf-runner Feb 8, 2025
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 80.35714% with 11 lines in your changes missing coverage. Please review.

Project coverage is 76.8%. Comparing base (a8f6e5d) to head (93d0a64).
Report is 1 commits behind head on nightly.

Files with missing lines Patch % Lines
crates/common/src/config.rs 66.6% 4 Missing ⚠️
crates/light-client-prover/src/services.rs 0.0% 3 Missing ⚠️
crates/soft-confirmation-rule-enforcer/src/call.rs 0.0% 2 Missing ⚠️
bin/citrea/src/rollup/bitcoin.rs 0.0% 1 Missing ⚠️
crates/light-client-prover/src/da_block_handler.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
bin/citrea/src/rollup/mock.rs 75.5% <100.0%> (ø)
bin/citrea/src/rollup/mod.rs 79.4% <ø> (ø)
crates/batch-prover/src/da_block_handler.rs 74.6% <100.0%> (ø)
crates/batch-prover/src/lib.rs 100.0% <100.0%> (ø)
crates/batch-prover/src/proving.rs 81.6% <100.0%> (-0.1%) ⬇️
crates/batch-prover/src/rpc.rs 60.6% <100.0%> (-0.9%) ⬇️
crates/batch-prover/src/runner.rs 84.3% <ø> (ø)
crates/bitcoin-da/src/spec/address.rs 53.3% <ø> (ø)
crates/citrea-stf/src/genesis_config.rs 100.0% <100.0%> (ø)
crates/citrea-stf/src/runtime.rs 100.0% <100.0%> (ø)
... and 14 more

... and 8 files with indirect coverage changes

@eyusufatik eyusufatik merged commit 7761c58 into nightly Feb 8, 2025
13 checks passed
@eyusufatik eyusufatik deleted the esad/refactor-dependency-and-features branch February 8, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants