Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test target #1840

Merged
merged 3 commits into from
Feb 8, 2025
Merged

Fix test target #1840

merged 3 commits into from
Feb 8, 2025

Conversation

rakanalh
Copy link
Contributor

@rakanalh rakanalh commented Feb 8, 2025

Description

Fixes the problem that @kpp had where make test [TEST-NAME] did not work as before.

Now we're passing along all additional params we receive for make test to make sure that they are available when test-ci is invoked.

@rakanalh rakanalh requested a review from eyusufatik as a code owner February 8, 2025 12:54
@auto-assign auto-assign bot requested a review from jfldde February 8, 2025 12:54
kpp
kpp requested changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@kpp kpp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually need to be able to run make test [TESTNAME] -- --nocapture. With this PR I need to pass make test -- -- --nocapture.

@codecov Codecov
Copy link

codecov bot commented Feb 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.3%. Comparing base (e14b40e) to head (00a2ae5).
Report is 3 commits behind head on nightly.

Additional details and impacted files

see 5 files with indirect coverage changes

@rakanalh rakanalh merged commit c61a5b1 into nightly Feb 8, 2025
@rakanalh rakanalh deleted the rakanalh/fix-test-target branch February 8, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpp kpp kpp approved these changes

@eyusufatik eyusufatik eyusufatik approved these changes

@yaziciahmet yaziciahmet yaziciahmet approved these changes

@jfldde jfldde Awaiting requested review from jfldde

Assignees

@rakanalh rakanalh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rakanalh @kpp @eyusufatik @yaziciahmet