Mark base image as experimental #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces an apko:experimental struct tag so that we can ignore it in our reflection-based terraform schema generation in terraform-provider-apko. This wasn't a problem before because we ignored pointers, but when we moved GID to a *uint32, we started ignoring it in our terraform provider. Fixing that (by dereferencing pointers in the reflection code) had an unfortunate effect of bringing the base image stuff into the generated schema, which I don't want to do yet because it's experimental. Adding this tag lets me filter it out without hardcoding specific field names (ew). Signed-off-by: Jon Johnson <[email protected]>
imjasonh
approved these changes
Dec 20, 2024
jonjohnsonjr
added a commit
to jonjohnsonjr/terraform-provider-apko
that referenced
this pull request
Dec 20, 2024
See chainguard-dev/apko#1453 Since GID is optional and 0 is a valid value, we needed a way to distinguish between unset and 0, so GID became a pointer. This broke the reflect code (labeled HACK) that punted on pointers. I've updated that code to handle pointers but also to ignore any fields marked with `apko:"experimental"` because I don't want to pollute the schema with them. Signed-off-by: Jon Johnson <[email protected]>
jonjohnsonjr
added a commit
to jonjohnsonjr/terraform-provider-apko
that referenced
this pull request
Dec 20, 2024
See chainguard-dev/apko#1453 Since GID is optional and 0 is a valid value, we needed a way to distinguish between unset and 0, so GID became a pointer. This broke the reflect code (labeled HACK) that punted on pointers. I've updated that code to handle pointers but also to ignore any fields marked with `apko:"experimental"` because I don't want to pollute the schema with them. Signed-off-by: Jon Johnson <[email protected]>
jonjohnsonjr
added a commit
to jonjohnsonjr/terraform-provider-apko
that referenced
this pull request
Dec 30, 2024
See chainguard-dev/apko#1453 Since GID is optional and 0 is a valid value, we needed a way to distinguish between unset and 0, so GID became a pointer. This broke the reflect code (labeled HACK) that punted on pointers. I've updated that code to handle pointers but also to ignore any fields marked with `apko:"experimental"` because I don't want to pollute the schema with them. Signed-off-by: Jon Johnson <[email protected]>
jonjohnsonjr
added a commit
to jonjohnsonjr/terraform-provider-apko
that referenced
this pull request
Dec 30, 2024
See chainguard-dev/apko#1453 Since GID is optional and 0 is a valid value, we needed a way to distinguish between unset and 0, so GID became a pointer. This broke the reflect code (labeled HACK) that punted on pointers. I've updated that code to handle pointers but also to ignore any fields marked with `apko:"experimental"` because I don't want to pollute the schema with them. Signed-off-by: Jon Johnson <[email protected]>
jonjohnsonjr
added a commit
to chainguard-dev/terraform-provider-apko
that referenced
this pull request
Dec 30, 2024
Stealing most of this from #434 but cleaned up the reflection code. Handle experiment tag and pointers in reflect See chainguard-dev/apko#1453 Since GID is optional and 0 is a valid value, we needed a way to distinguish between unset and 0, so GID became a pointer. This broke the reflect code (labeled HACK) that punted on pointers. I've updated that code to handle pointers but also to ignore any fields marked with `apko:"experimental"` because I don't want to pollute the schema with them. --------- Signed-off-by: Josh Dolitsky <[email protected]> Signed-off-by: Jon Johnson <[email protected]> Co-authored-by: Josh Dolitsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an apko:experimental struct tag so that we can ignore it in our reflection-based terraform schema generation in terraform-provider-apko.
This wasn't a problem before because we ignored pointers, but when we moved GID to a *uint32, we started ignoring it in our terraform provider. Fixing that (by dereferencing pointers in the reflection code) had an unfortunate effect of bringing the base image stuff into the generated schema, which I don't want to do yet because it's experimental. Adding this tag lets me filter it out without hardcoding specific field names (ew).