pkg/apk: switch to SHA2-256 based signatures by default #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove commented out support for dual-signing, as it is not correctly supported by anything (non-deterministic validation, leading to trusting weakest signature, rather than strongest one). Switch default signing type to RSA256 (RSA signature over SHA2-256 message digest). Provide environment variable opt-out to switch back to RSA (RSA signature over SHA1 message digest). This allows to roll this out, with a runtime escape hatch. BTW I am not sure if anybody uses this API, as I am failing to find any references to SignIndex() call anywhere...
xnox
added a commit
to xnox/melange
that referenced
this pull request
Dec 13, 2024
Switch to SHA2-256 signature by default for the `melange sign` command. Use the same runtime opt-out back to SHA1 signatures as apko. With apko from: - chainguard-dev/apko#1440 This will use RSA256 signature type for both .apk & APKINDEX.tar.gz signing.
jonjohnsonjr
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove commented out support for dual-signing, as it is not correctly
supported by anything (non-deterministic validation, leading to
trusting weakest signature, rather than strongest one).
Switch default signing type to RSA256 (RSA signature over SHA2-256
message digest).
Provide environment variable opt-out to switch back to RSA (RSA
signature over SHA1 message digest).
This allows to roll this out, with a runtime escape hatch.
If successful, runtime escape hatch can be reverted.
All tests pass, as support for validating RSA/RSA256/dual signatures
was already landed previously.
This api is used by melange and has been cross-tested with melange (using replace go.mod directive pointing at this proposed apko code).