chore: bump subxt to 0.33 #4693
Conversation
| @@ -910,7 +910,7 @@ impl SignedExtrinsicClientBuilderTrait for SignedExtrinsicClientBuilder { | |||
| )? | |||
| .submit_and_watch() | |||
| .await? | |||
| .wait_for_in_block() | |||
There was a problem hiding this comment.
they removed this in 0.33 as it is unreliable
There was a problem hiding this comment.
@AlastairHolmes FYI details are in this PR: paritytech/subxt#1237
Could this be related to the SC Client hash mismatch issues we are seeing?
There was a problem hiding this comment.
I don't believe so, my understanding is the issue they are discussing is that subscription could give you a block hash that you then cannot request the header of. But in our problem case, that is not happening.
I'm just glad we implemented our own versions of these.
There was a problem hiding this comment.
We should probably increase the timeout its only 30 seconds
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4693 +/- ##
=====================================
Coverage 72% 72%
=====================================
Files 415 415
Lines 68749 68787 +38
Branches 68749 68787 +38
=====================================
+ Hits 49334 49367 +33
Misses 17006 17006
- Partials 2409 2414 +5 ☔ View full report in Codecov by Sentry. |
kylezs
requested review from
jerryafr and
acdibble
and removed request for
a team
Resolves the cargo-audit issue (https://rustsec.org/advisories/RUSTSEC-2022-0093), as this bumps the ed25519-dalek dependency to v2