Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump substrate deps to polkadot-sdk 1.6 #4504

Merged
merged 27 commits into from
Feb 19, 2024
Merged

Conversation

dandanlen
Copy link
Collaborator

@dandanlen dandanlen commented Feb 8, 2024

Pull Request

Closes: PRO-1129

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

  • Updates our substrate dependency to the 1.6 polkadot release.
  • Bump the rust compiler version.
  • Fix some new clippy lints.
  • Cargo-updates our dependencies.
  • Resolve some cargo-audit issues.
  • Update cryptography libs to latest version now that they are compatible with substrate. (@msgmaxim please take a look: 6aa9e2a)

Most notable substrate changes since 1.1:

  • Genesis configs are now serializable as JSON.
  • BTreeSet no longer supports StorageDecodeLength (now uses the wonderfully named StorageDecodeNonDedupLength).
  • There's a derive_impl macro that makes it easier to 'inherit' runtime implementations from a base config (used throughout the mocks).
  • The Imbalances trait had a new method added.
  • All accounts need to have a non-zero reference counter. This includes governance accounts (see 059ccea)

The only thing I consciously ignored was this change: paritytech/polkadot-sdk#2390

I doesn't really apply to us - we don't have any lints configured at the workspace level. I opened a Linear issue to collect our scattered linting config in a workspace-level file but I don't think it's high priority. (PRO-1117)

@dandanlen dandanlen requested review from niklasnatter and GabrielBuragev and removed request for a team February 8, 2024 14:04
@dandanlen dandanlen marked this pull request as draft February 8, 2024 14:05
@dandanlen
Copy link
Collaborator Author

Converting back to draft - looks like I need to update something in CI.

@msgmaxim
Copy link
Contributor

Update cryptography libs to latest version now that they are compatible with substrate. (@msgmaxim please take a look: d902636)

This part looks good to me 👍

@dandanlen dandanlen force-pushed the upgrade/polkadot-sdk-1.6 branch 2 times, most recently from b4b5cfe to afd1d73 Compare February 16, 2024 10:59
@dandanlen dandanlen force-pushed the upgrade/polkadot-sdk-1.6 branch from afd1d73 to b40c433 Compare February 16, 2024 12:13
@dandanlen dandanlen marked this pull request as ready for review February 16, 2024 12:14
@dandanlen dandanlen merged commit 4a0a97b into main Feb 19, 2024
41 of 42 checks passed
@dandanlen dandanlen deleted the upgrade/polkadot-sdk-1.6 branch February 19, 2024 10:17
syan095 added a commit that referenced this pull request Feb 26, 2024
…ero-liquidity

* origin/main: (28 commits)
  feat(custom-rpc): add broker info [WEB-925] (#4560)
  chore: upgrade solana version (#4567)
  fix: continuous adapter (PRO-684) (#4503)
  fix: Wait for ThresholdSignature success before switching to NewKeysActivated (#4534)
  chore: remove un-needed serde derives from EncodedAddress (#4565)
  fix: more lenient max deposit fee in bouncer test (#4564)
  chore: build persa bins instead of fetch (#4554)
  feat: deploy L2 contracts upon localnet startup and send L2 TXs 📑 (#4558)
  feat: debug logs on runtime upgrade test (#4556)
  feature/PRO-1038/pool-fee-rpc (#4459)
  chore: update bootnodes in chainspec ✨ (#4456)
  fix: allow test coverage to run (#4555)
  refactor/pro-1160/remove-side-side-map (#4489)
  fix: activate missing migrations (#4550)
  chore: remove cf-build (#4551)
  feat: extensible multi-key rotator (#4546)
  fix: ensure channel open fee can be paid in benchmarks (#4544)
  feat: bump substrate deps to polkadot-sdk 1.6 (#4504)
  fix: upgrade-test should restart the chainflip-nodes on an incompatible upgrade (#4490)
  test: add small v3 migration test (#4543)
  ...

# Conflicts:
#	state-chain/pallets/cf-pools/src/tests.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants