Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add boost fee field to DepositChannelDetails #4492

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Conversation

marcellorigotti
Copy link
Contributor

Pull Request

Closes: PRO-1170

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

  • Use the boost_fee parameter passed in open_swap_channel/open_liquidity_channel extrinsic and add it to the DepositChannelDetails
  • Migrate old channelDetails to include this new field, set to 0 for "old" channels

@dandanlen
Copy link
Collaborator

LGTM after a quick look, will let Kyle do an in-depth review.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (0b34477) 73% compared to head (d2aed29) 73%.
Report is 4 commits behind head on main.

Files Patch % Lines
state-chain/pallets/cf-lp/src/tests.rs 70% 0 Missing and 12 partials ⚠️
state-chain/runtime/src/chainflip.rs 25% 3 Missing ⚠️
.../src/migrations/deposit_channels_with_boost_fee.rs 97% 1 Missing and 1 partial ⚠️
state-chain/pallets/cf-ingress-egress/src/lib.rs 90% 0 Missing and 1 partial ⚠️
state-chain/pallets/cf-lp/src/lib.rs 80% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4492   +/-   ##
=====================================
- Coverage     73%     73%   -0%     
=====================================
  Files        397     396    -1     
  Lines      67365   67413   +48     
  Branches   67365   67413   +48     
=====================================
+ Hits       48899   48927   +28     
- Misses     15890   15898    +8     
- Partials    2576    2588   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kylezs kylezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, a little clean up and a little more testing then good to go I think 👌

@marcellorigotti marcellorigotti changed the title Feature/pro 1170 feat: add boost fee field to DepositChannelDetails Feb 7, 2024
@kylezs kylezs requested a review from msgmaxim February 7, 2024 15:05
@kylezs
Copy link
Contributor

kylezs commented Feb 7, 2024

Tagging @msgmaxim for visibility too

Copy link
Contributor

@kylezs kylezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Nice!

@tomjohnburton tomjohnburton changed the title feat: add boost fee field to DepositChannelDetails feat: add boost fee field to DepositChannelDetails (non-breaking) Feb 7, 2024
@tomjohnburton tomjohnburton changed the title feat: add boost fee field to DepositChannelDetails (non-breaking) feat: add boost fee field to DepositChannelDetails nbr Feb 7, 2024
@kylezs kylezs changed the title feat: add boost fee field to DepositChannelDetails nbr feat: add boost fee field to DepositChannelDetails Feb 8, 2024
@kylezs kylezs merged commit a872e5d into main Feb 8, 2024
43 checks passed
@kylezs kylezs deleted the feature/pro-1170 branch February 8, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants