-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add boost fee field to DepositChannelDetails #4492
Conversation
state-chain/pallets/cf-ingress-egress/src/migrations/deposit_channels_with_boost_fee.rs
Show resolved
Hide resolved
LGTM after a quick look, will let Kyle do an in-depth review. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4492 +/- ##
=====================================
- Coverage 73% 73% -0%
=====================================
Files 397 396 -1
Lines 67365 67413 +48
Branches 67365 67413 +48
=====================================
+ Hits 48899 48927 +28
- Misses 15890 15898 +8
- Partials 2576 2588 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, a little clean up and a little more testing then good to go I think 👌
state-chain/pallets/cf-ingress-egress/src/migrations/deposit_channels_with_boost_fee.rs
Show resolved
Hide resolved
state-chain/pallets/cf-ingress-egress/src/migrations/deposit_channels_with_boost_fee.rs
Outdated
Show resolved
Hide resolved
state-chain/pallets/cf-ingress-egress/src/migrations/deposit_channels_with_boost_fee.rs
Outdated
Show resolved
Hide resolved
state-chain/pallets/cf-ingress-egress/src/migrations/deposit_channels_with_boost_fee.rs
Show resolved
Hide resolved
Tagging @msgmaxim for visibility too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 Nice!
Pull Request
Closes: PRO-1170
Checklist
Please conduct a thorough self-review before opening the PR.
Summary