Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Use python 3.5 for make html and make doctest #342

Merged
merged 1 commit into from
Oct 28, 2017

Conversation

sonots
Copy link
Contributor

@sonots sonots commented Oct 23, 2017

To avoid cyfunction is not a Python function as:

/work/cupy/docs/source/reference/generated/cupy.cuda.Event.rst:53: WARNING: error while formatting arguments for cupy.cuda.Event.record: <cyfunction Event.record at 0x2aea1bcb8d10> is not a Python function

It seems insepect.isfunction(cyfuction) returns True from python 3.4 https://groups.google.com/forum/#!topic/cython-users/FvcMPk9n2X8. Using python >= 3.4 resolves the issue.

ref. cupy/cupy#306 (comment)


All of three must be merged together:

@sonots sonots changed the title Use python 3.5 for doctest Use python 3.5 for doc Oct 23, 2017
@sonots sonots changed the title Use python 3.5 for doc Use python 3.5 for make html and make doctest Oct 24, 2017
@okuta
Copy link
Member

okuta commented Oct 26, 2017

CuPy side is ready.

@okuta okuta self-assigned this Oct 28, 2017
@okuta
Copy link
Member

okuta commented Oct 28, 2017

LGTM!

@okuta okuta merged commit 95f3647 into chainer:master Oct 28, 2017
@sonots sonots deleted the doctest_python3.5 branch October 29, 2017 03:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants