Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember note resize #550

Merged
merged 17 commits into from
Jul 16, 2022
Merged

Remember note resize #550

merged 17 commits into from
Jul 16, 2022

Conversation

joeyballentine
Copy link
Member

@joeyballentine joeyballentine commented Jul 14, 2022

I committed a grave sin with this. Nothing else uses this input though so I hope you can forgive me.

The other option if JSON stringifying this is a bit too much, is just using inOutId +1 and +2 to store the size. This would mean you could never have inputs come after a textarea though (not that anything else is using or will ever use this)

Closes #457

@RunDevelopment
Copy link
Member

I don't think this is a good solution. You essentially made the text area input exclusive to the Note node. There are several text inputs that could benefit for being multiline:

It would be nice if all of those were also resizable.

Could we not just add a new node data property inputSize: Record<InputId, Size> to track this size instead?

@joeyballentine joeyballentine marked this pull request as draft July 15, 2022 15:08
@joeyballentine
Copy link
Member Author

@RunDevelopment So interestingly enough, after making the change to use a new inputSize property, it is doing the same thing that the iteratorSize property does when you resize it where it flashes between the previous and the next size. I have no idea what's causing that or how to fix it :/

@joeyballentine joeyballentine marked this pull request as ready for review July 16, 2022 04:07
@joeyballentine joeyballentine merged commit 11a358f into main Jul 16, 2022
@joeyballentine joeyballentine deleted the remember-note-resize branch July 22, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Note resize not preserved
2 participants