Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "order" dropdown for both spritesheet nodes #2878

Merged
merged 4 commits into from
May 19, 2024

Conversation

joeyballentine
Copy link
Member

closes #2851

image

@RunDevelopment
Copy link
Member

The "row x column" and "column x row" names are confusing. The infix "x" typically denotes multiplication which most people think of as commutative. By this interpretation, these two options describe the same thing (a*b = b*a).

The terms you are looking for are row major and column major. Unfortunately, these terms aren't really used outside CS and math, so we need to explain them. I would probably give a short description of both and then use code blocks to visually show the difference like this:

Row major:
→ 0 1 2
  3 4 5
  6 7 8

Column major:
↓ 0 3 6
  1 4 7
  2 5 8

Also, the description should be a hint (so with a little (i)) IMO. We can't expect people to know this, so we should make the explanation easy to access.

@joeyballentine joeyballentine merged commit 0f0762f into main May 19, 2024
14 checks passed
@joeyballentine joeyballentine deleted the row-x-column-spritesheet branch May 19, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants