-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate electron imports between main and renderer, use IPC to replace most renderer-side electron imports #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, I learned a couple things:
|
Ok, back to a draft. i broke chain copy and paste from this |
I think i've tested all the different ways to copy and paste, and everything looks good now. |
RunDevelopment
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
electron provides (and recommends using) these segregated imports (electron/renderer, electron/main, electron/common) in order to ensure you aren't accidentally importing something in the wrong place.
I discovered a few places where we were importing main-process electron code in the renderer and have fixed it, along with modifying (almost) all the electron imports to be the helper ones. (I left one import the same because if I didn't then it thinks electron doesn't exist. Try it yourself, its really strange)
I'm opening this as a draft, because there's still somewhere that is importing main process code where it shouldn't, and it is causing chaiNNer to crash on startup.