Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Strengthen Normals" to "Scale Normals" #2500

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Rename "Strengthen Normals" to "Scale Normals" #2500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...textures/normal_map/strengthen_normals.py → ...rial_textures/normal_map/scale_normals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@

@normal_map_group.register(
schema_id="chainner:image:strengthen_normals",
name="Strengthen Normals",
name="Scale Normals",
description=[
"Strengths and weakens the normals in the given normal map. Only the R and G channels of the input image will be used. The output normal map is guaranteed to be normalized.",
"Strengths or weakens the normals in the given normal map. Only the R and G channels of the input image will be used. The output normal map is guaranteed to be normalized.",
"Conceptually, this node is equivalent to `chainner:image:add_normals` with the strength of the second normal map set to 0.",
],
icon="MdExpand",
Expand All @@ -36,7 +36,7 @@
),
],
)
def strengthen_normals_node(
def scale_normals_node(
n: np.ndarray, strength: int, method: AdditionMethod
) -> np.ndarray:
return xyz_to_bgr(strengthen_normals(method, n, strength / 100))