Optimize Split Transparency output for subsequent operations #2391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While optimizing
resize
, I learned that creating an RGB image by returning the first 3 channels of an RGBA image can cause very significant slow downs in subsequent operations. This is because iterating over array slices is a lot slower than iterating over contiguous memory. Slices also might require a copy to make them contiguous (some image operations are implemented in such a way that they require contiguous memory).I also want to say that we generally don't need to worry about slices being bad for performance. They are only bad if they can be trivially avoided, like in Split Transparency. For RGB images, this node was creating a new RGBA image and then returned 2 slices to that RGBA image. So I added some code to return the RGB image and new image instead. This not only improves performance for subsequent operations, it also allocates less memory.