-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iterator Rewrite: Part 1 #2254
Iterator Rewrite: Part 1 #2254
Conversation
Without type information I dont think that can be avoided. I could just automatically convert those to arrays I guess? |
Let's not make a bug a feature, okay? Since we should make iterators a type in the type system anyway, we can fix it in later PRs I guess. On that note: we should make issues for the iterator things we want to change/fix. |
Co-authored-by: Michael Schmidt <[email protected]>
…terator-rewrite-attempt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; We still need to polish iterators a lot, but this is a solid foundation. Let's merge it!
Part 1 of the Iterator Rewrite ™️. While not everything we want to be able to accomplish out of iterators, it works so much better than the current system.
Improvements:
Drawbacks:
Open Questions:
Things that should be extensively tested:
Future work:
Issues that get closed as a result of this: