Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open .chn files on macOS after first start #2150

Merged
merged 3 commits into from
Sep 3, 2023
Merged

open .chn files on macOS after first start #2150

merged 3 commits into from
Sep 3, 2023

Conversation

stonerl
Copy link
Collaborator

@stonerl stonerl commented Aug 26, 2023

fixes #2131

@stonerl

This comment was marked as outdated.

Sign in to view
@stonerl stonerl marked this pull request as draft August 28, 2023 20:57
@stonerl
Copy link
Collaborator Author

stonerl commented Aug 28, 2023

@RunDevelopment

I revised it. We basically wait until the main window gets opened. If the open-fileevent hasn't fired until then. The first listener is removed, and the new listener takes over. Is this sensible?

@stonerl stonerl marked this pull request as ready for review August 28, 2023 22:53
@RunDevelopment
Copy link
Member

Yup, that works. Very nice. Thanks.

RunDevelopment
RunDevelopment requested changes Aug 30, 2023
View reviewed changes
joeyballentine
joeyballentine approved these changes Sep 3, 2023
View reviewed changes
Copy link
Member

@joeyballentine joeyballentine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably good now. Thanks!

@joeyballentine joeyballentine merged commit 572bb9c into chaiNNer-org:main Sep 3, 2023
@stonerl stonerl deleted the cold-start branch September 3, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment requested changes

@joeyballentine joeyballentine joeyballentine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macOS: Open .chn files on cold start
3 participants
@stonerl @RunDevelopment @joeyballentine