update pytorch on apple silicon to 2.0.1 #2139
Conversation
|
I think we should update everything to PyTorch 2.0 all at once. Right now, PyTorch could be completely broken on mac and we wouldn't know, because our CI doesn't test this. |
|
Shall I close it then? |
|
I did some basic testing, and it seems to be working fine. That doesn't replace CI, though.
|
Not sure. @joeyballentine What's the state of PyTorch 2.0 again? Did we want to wait for 2.1? Also, if we do go for 2.0 (or 2.1), we should probably add support for py 3.11 as well since that requires >=2.0. |
|
I want to update to 3.11 and 2.0 at the same time. Ideally we'd wait until 2.1 since that comes out in October but I suppose we could also just update to that when it comes out instead of waiting. Just give me a little time and I'll work on what's necessary for 3.11. The reason we need to do both is that 2.0 is slower than the current version we use. For Mac that might not matter, but I don't want to have a major version difference between platforms and accidentally cause issues from that |
|
Closing in favor of #2143 |
fixes #2138