Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force a backend restart when killing the backend takes over 2.5s #1521

Merged
merged 16 commits into from
Feb 5, 2023
Merged

Force a backend restart when killing the backend takes over 2.5s #1521

merged 16 commits into from
Feb 5, 2023

Conversation

joeyballentine
Copy link
Member

No description provided.

RunDevelopment
RunDevelopment reviewed Jan 30, 2023
View reviewed changes
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 1sec might be a bit too harsh. Maybe we could give it 5sec? Restarting the backend also takes some time, and we also lose its cache (e.g. Load Image nodes), so the next run will take longer.

src/renderer/contexts/ExecutionContext.tsx Outdated Show resolved Hide resolved
RunDevelopment
RunDevelopment reviewed Feb 4, 2023
View reviewed changes
src/common/Backend.ts Outdated Show resolved Hide resolved
src/renderer/contexts/ExecutionContext.tsx Outdated Show resolved Hide resolved
@joeyballentine joeyballentine changed the title Force a backend restart when killing the backend takes over a second Force a backend restart when killing the backend takes over 2.5s Feb 5, 2023
@joeyballentine joeyballentine merged commit cfa908f into main Feb 5, 2023
@joeyballentine joeyballentine deleted the force-restart-on-stop branch February 5, 2023 21:34
@RunDevelopment RunDevelopment mentioned this pull request Jun 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theflyingzamboni theflyingzamboni theflyingzamboni left review comments

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joeyballentine @RunDevelopment @theflyingzamboni