Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "Restart chaiNer" button skips the unsaved data dialog #1338

Closed
0x4E69676874466F78 opened this issue Dec 4, 2022 · 4 comments · Fixed by #2132
Closed

The "Restart chaiNer" button skips the unsaved data dialog #1338

0x4E69676874466F78 opened this issue Dec 4, 2022 · 4 comments · Fixed by #2132
Labels
bug Something isn't working

Comments

@0x4E69676874466F78
Copy link

and results in loss of data.
@0x4E69676874466F78 0x4E69676874466F78 added the bug Something isn't working label Dec 4, 2022
@RunDevelopment
Copy link
Member

The Restart chainner button is kinda broken anyway in that we don't actually need to restart chainner. We should finally implement restarting just the backend.

@joeyballentine
Copy link
Member

Don't forget there's also the restart button in settings, which is needed for applying certain settings like disabling hardware acceleration.

For the restart in the dependency manager, it should be fine to just restart the backend and refresh everything linked to the backend (nodes, etc)

@0x4E69676874466F78

This comment was marked as outdated.

Sign in to view
@RunDevelopment
Copy link
Member

#1348 removed one "Restart chaiNNer" button, so we got a bit of progress.

stonerl added a commit to stonerl/chaiNNer that referenced this issue Aug 22, 2023
@stonerl
handle unsaved changes on reboot
a6a562c 
fixes chaiNNer-org#1338
@stonerl stonerl mentioned this issue Aug 22, 2023
Merged
joeyballentine pushed a commit that referenced this issue Aug 23, 2023
@stonerl
handle unsaved changes on reboot (#2132)
703f384 
* handle unsaved changes on reboot

fixes #1338

* renamed parameters

* don’t kill the backend on Cancel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle unsaved changes on reboot stonerl/chaiNNer
3 participants
@0x4E69676874466F78 @RunDevelopment @joeyballentine