Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LogInterceptor constant #2375

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make LogInterceptor constant #2375

wants to merge 1 commit into from
+8 −8

Conversation

bambinoua
Copy link

Just add the const keyword for LogInterceptor constructor and make all fields final for using it as default parameter.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

@bambinoua bambinoua requested a review from a team as a code owner February 6, 2025 11:18
@kuhnroyal
Copy link
Member

While I agree with this and immutability in general, this is a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bambinoua @kuhnroyal