Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package Update: CFPB Design System - 0.35.0 #289

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Package Update: CFPB Design System - 0.35.0 #289

merged 2 commits into from
Jan 24, 2024

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented Jan 23, 2024 •
edited
Loading

Pulls in Checkbox changes from a DS update: cfpb/design-system#1889

Changes:

  • Checkbox - Includes Status Styling (Error/Warning/Success)

To Test:

  • yarn install
  • yarn storybook
  • Go to a Checkbox component and then edit the first div's class to be:
m-form-field m-form-field__checkbox m-form-field__checkbox__warning
  • You should see the Checkbox's border turn yellow.

Example Result(s) should be

Screenshot 2024-01-23 at 4 58 00 PM

@shindigira
Package Update: CFPB Design System - 0.35.0
e3946ae 
Changes:
- Checkbox - Includes Status Styling (Error/Warning/Success)
@netlify Netlify
Copy link

netlify bot commented Jan 23, 2024 •
edited
Loading

✅ Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit 1a80e81
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/65b0359aa0c3110008aced7a
😎 Deploy Preview https://deploy-preview-289--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

meissadia
meissadia approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shindigira shindigira merged commit d8a2c08 into main Jan 24, 2024
7 of 9 checks passed
@shindigira shindigira deleted the Update-DS-0.35.0 branch January 24, 2024 14:36
@billhimmelsbach billhimmelsbach mentioned this pull request Jan 30, 2024
Merged
billhimmelsbach added a commit to cfpb/sbl-frontend that referenced this pull request Jan 30, 2024
@billhimmelsbach
fix(deps): add latest DSR, includes DS 0.35.0 updates (#199)
022ac3a 
A companion to
[#289](cfpb/design-system-react#289) in the DSR.

## Changes

- Runs `yarn up -i design-system-react`

## How to test this PR

1. Do you see the updates to the DS like focus error states on
checkboxes on "Complete your user profile"? (hover error state is coming
in a later PR)

## Screenshots
![Screenshot 2024-01-30 at 3 58 20
AM](https://github.com/cfpb/sbl-frontend/assets/19983248/ac848f17-d796-42e6-aa8f-153049ac8e28)


## Notes

- more DSR changes are coming, but we should keep this updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meissadia meissadia meissadia approved these changes

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach billhimmelsbach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shindigira @meissadia