Fix/memory leak in package case checker #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdecock
force-pushed
the
fix/memory-leak-in-PackageCaseChecker
branch
from
3ed8d1a to
806fb4c
Compare
xdecock
commented
May 17, 2020
| final String key = componentName.toLowerCase(); | ||
| if (!expressionCheckRegister.containsKey(key)) { | ||
| expressionCheckRegister.put(key, new ArrayList<PackageCaseCheckerEntry>()); | ||
| if (!fromExpressionRegister) { |
There was a problem hiding this comment.
The most important part of the fix, is here, to avoid injecting the same expression multiple times, the rest was just "optimization while trying to understand what was going on"
There was a problem hiding this comment.
Thanks for the hard work. Looks good at a high level -and I'm trusting the unit tests :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple optimisations and a fix of the memory leak created when a lot of classes have the same basename.