Remove dependencies defined in cfparser and add git info to artifact. #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There shouldn't be any need to redefine the dependencies defined in cfparser, so I've removed those, and then while we can add a git hash to the actual build artifact name, it doesn't really play nice with Maven (works fine for p2/Eclipse repositories, but that's besides the point), so the next best thing is to include something that can be parsed by a maven plugin or some such (what this does), so build artifacts will now at least have a git.properties file inside them containing oodles of info about exactly what version was built.