Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code and add tests to check in return statements #108

Merged
merged 15 commits into from
Oct 18, 2015
Merged

Update code and add tests to check in return statements #108

merged 15 commits into from
Oct 18, 2015

Conversation

justinmclean
Copy link
Contributor

Code before wasn't checking return statements. However it looks like may be a CFlint bug where expressions in return statements are not being parsed?

@ryaneberly
Copy link
Contributor

@justinmclean
cfreturn and cfelseif expressions were not being processed. This is fixed. I used reflection on the cfreturn piece until the related fix in the cf parser code is live.

@justinmclean
Copy link
Contributor Author

Added more tests, all pass, IMO good to merge.

@ryaneberly
Copy link
Contributor

+1.

justinmclean added a commit that referenced this pull request Oct 18, 2015
@justinmclean
Merge pull request #108 from cflint/updateBooleanChecks
d812a52 
Update code and add tests to check in return statements
@justinmclean justinmclean merged commit d812a52 into dev Oct 18, 2015
@justinmclean justinmclean deleted the updateBooleanChecks branch October 18, 2015 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinmclean @ryaneberly @jjames967