Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse error for numeric struct keys #599

Closed
KamasamaK opened this issue Oct 23, 2018 · 7 comments
Closed

Parse error for numeric struct keys #599

KamasamaK opened this issue Oct 23, 2018 · 7 comments
Labels
Milestone

Comments

@KamasamaK
Copy link
Collaborator

KamasamaK commented Oct 23, 2018

On the latest 1.5.0 build, I am getting PARSE_ERRORs on numeric struct keys. This does not occur with 1.4.1.

Even worse, it does it for quoted struct keys, which is recommended in one of the rules.

Here is an example with both

<cfset var foo =
	{
		0: "priority",
		5: "status",
		10: "name",
		"abc": "date",
		"xyz": "category"
	}
>
@KamasamaK KamasamaK added the bug label Oct 23, 2018
@ryaneberly
Copy link
Contributor

ryaneberly commented Oct 23, 2018 via email

@KamasamaK KamasamaK added this to the 1.5.0 milestone Nov 29, 2018
ryaneberly pushed a commit that referenced this issue Sep 11, 2019
@ryaneberly
Copy link
Contributor

updated cfparser again, seems to be working with the latest

@KamasamaK KamasamaK reopened this Sep 15, 2019
@KamasamaK
Copy link
Collaborator Author

They're not getting PARSE_ERRORs anymore, but now they're getting PLUGIN_ERRORs.

@ryaneberly
Copy link
Contributor

Thanks @KamasamaK . I tried it on the test ParseError\keys_599.cfm -- and don't see the issue. Can you help me duplicate it.

@KamasamaK
Copy link
Collaborator Author

I cannot reproduce it with your .cflintrc, which is probably because it is only including PARSE_ERROR.

@KamasamaK
Copy link
Collaborator Author

I've rebuilt today and it looks good good now.

@ryaneberly
Copy link
Contributor

ryaneberly commented Sep 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants