Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent ALLCAPS #544

Closed
jimpriest opened this issue Feb 25, 2018 · 2 comments
Closed

Inconsistent ALLCAPS #544

jimpriest opened this issue Feb 25, 2018 · 2 comments
Assignees

Comments

@jimpriest
Copy link

Using 1.3.0.

Given this function:

public string function ANOTHERMETHOD(){
	var FO = "Bar";
	local.TEST = "Foo";
	LOCAL.test = "FooBar";
	return LOCAL.FO;	
}

And this rule set:

{
	"rule": [],
	"includes": [
		{ "code": "AVOID_USING_WRITEDUMP" },
		{ "code": "METHOD_ALLCAPS_NAME " },
		{ "code": "EXCESSIVE_FUNCTIONS" },
		{ "code": "VAR_ALLCAPS_NAME" },
		{ "code": "SCOPE_ALLCAPS_NAME " },
		{ "code": "VAR_TOO_SHORT" }
	],
  "inheritParent": false
}

I get no warnings for the capitalized var "var FO" nor the capitalized "LOCAL" scope.

VAR_ALLCAPS_NAME:2
VAR_TOO_SHORT:1
METHOD_ALLCAPS_NAME:1

@ryaneberly ryaneberly added this to the 1.4.1 milestone Jun 1, 2018
ryaneberly added a commit that referenced this issue Jun 1, 2018
@ryaneberly
Copy link
Contributor

@jimpriest
What is the full context that this function is running in? is it inside a component or inside a <script/> tag in a cfml file?

With either of those scenarios, it flags the items you reported missing.

@ryaneberly ryaneberly removed this from the 1.4.1 milestone Sep 15, 2018
@ryaneberly
Copy link
Contributor

I believe this is working as expected in 1.4.0. closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants