Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maven build fails using the ZIP file from GitHub since it needs the .git folder #363

Closed
ryaneberly opened this issue Jul 23, 2017 · 4 comments
Closed

Maven build fails using the ZIP file from GitHub since it needs the .git folder #363

ryaneberly opened this issue Jul 23, 2017 · 4 comments
Assignees
@denuno

Comments

@ryaneberly
Copy link
Contributor

No description provided.

denuno added a commit that referenced this issue Jul 25, 2017
@denuno
Make git.properties generation during build optional. Closes #363
12555eb
@denuno
Copy link
Collaborator

denuno commented Jul 25, 2017

Ha! Well, there goes the idea of using the git hash as a version number. Hadn't even thought about that, but one probably shouldn't require git just to build.

@ryaneberly
Copy link
Contributor Author

@denuno I think it remains a fine basic implementation. People doing releases will typically have a git clone. ... as long as we can get the build to not fail when using the zip repo.

@denuno
Copy link
Collaborator

denuno commented Jul 25, 2017

Indeed! This fixed that build fail at least. It's just funny how ubiquitous source control is in my mind now.

@ryaneberly
Copy link
Contributor Author

@denuno . Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denuno denuno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@denuno @ryaneberly